Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Jan 14, 2026

Inspired by #16244 (comment)

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a ada4a force-pushed the needless_impl_lint_pass branch from 93b645b to a45f2fc Compare January 14, 2026 17:19
@ada4a
Copy link
Contributor Author

ada4a commented Jan 14, 2026

Ok so the tests were complaining about this help message:

You may need to import it first: use rustc_session::declare_lint_pass;

I do have a somewhat working suggestion version of that, but it doesn't check if declare_lint_pass is already imported. Still, I pushed it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants